Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filters in OdkForm get submission media #330

Conversation

Anuj-Gupta4
Copy link
Contributor

@Anuj-Gupta4 Anuj-Gupta4 commented Jan 10, 2025

Added filter field to get submission media

@github-actions github-actions bot added the enhancement New feature or request label Jan 10, 2025
@Anuj-Gupta4 Anuj-Gupta4 changed the title feat: add support for filters in OdkForm get submission media Add support for filters in OdkForm get submission media Jan 10, 2025
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍

Although as a result I just noticed, ODK explicitly recommends we not use the GET version of this endpoint but the POST version: https://docs.getodk.org/central-api-submission-management/#exporting-form-submissions-to-csv-via-post

I wonder why it was implemented in this way in osm-fieldwork 🤔

We should probably make an issue and address this later

@spwoodcock spwoodcock merged commit 755e24a into hotosm:main Jan 10, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants